Repository navigation
fix: skip OpenVPN TCP preflight check for WireGuard and ProTun - #39
Closed
everettmorgan wants to merge 1 commit into
Closed
everettmorgan wants to merge 1 commit into
everettmorgan wants to merge 1 commit into
Conversation
everettmorgan
force-pushed
the
fix/skip-openvpn-tcp-check-for-wireguard
branch
from
October 30, 2026 15:52
a98e6db to
95f3e6b
Compare
Author
|
Closing this — it was a local dogfood experiment, not ready for upstream. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinuxNetworkManager.start()currently gates every connection attempt on a 5-second TCP probe againstself._vpnserver.openvpn_ports.tcp([443, 7770, 8443]), even when the selected protocol isWireguardorProtun:Why this is problematic for
WireguardandProtun:NMKillSwitch(where OpenVPN could try to bind through the dummy kill-switch interface).WGKillSwitchalready installs an explicit/32route to the VPN server on the physical interface beforestart()is called (andProtunpassesinfer_parent_connection=Trueto NetworkManager).VPN server NOT reachable→events.Timeoutfailures whenever OpenVPN TCP ports are filtered/unresponsive or while the physical interface is still settling afterWGKillSwitch'sdevice.reapply_async()call (see WireGuard connection fails on Python 3.14: run_in_executor socket checks always return False in tcpcheck.py #20).Change
requires_openvpn_tcp_check = Trueclass attribute onLinuxNetworkManager(preserving default behavior forOpenVPNand any other subclasses).requires_openvpn_tcp_check = FalseonWireguardandProtun.tests/python/networkmanager/core/test_networkmanager.py.Complements #25 and #36 without overlapping files.